@hoangdesu, I might be too much of a lay man to get this; apologies for ruining it. Can anyone explain?
- roke-julian-lockhart commented CommentRO
- nosuchipsu commented Comment
Turning point
NO - sience commented Comment
Linus wrote the commit or Antigravity?
SI - sadiq-bd commented Comment
If it works don't touch 👀
SA - mitkudubale38 commented Comment
What a legendary commit message! @torvalds
MI - jean-h77 commented Comment
here
JE - jcarlosn commented Comment
I was here :)
JC - mertcaners12 commented Comment
I was here
ME - vermaysha commented Comment
Login
VE - NI
- noeticstech commented Comment
wait what ...........Linus bro ??????????
NO - timilehin24 commented Comment
crazyyy
TI - trojan1988th commented Comment
Had to subscribe here... 🤔 is the programming itself.
TR - fendis0709 commented Comment
> Is this much better than I could do by hand? Sure is. Vibe-Coding di-notice atmint loh ya... 😅
FE - alirezaparsi commented Comment
Use Claude
AL - arnavgr commented Comment
no way
AR - mattheliu commented Comment
🤗
MA - shadowe1ite commented Comment
I was here
SH - schultz-dev0 commented Comment
This is truly history in the making.
SC - jonleopard commented Comment
I was here
JO - stussyum commented Comment
🫠
ST - techhuttv commented Comment
The goat
TE - aquaebm commented on issue #83 CommentPrefer SVF over DF1/DF2 biquads
You might also want to try implementing the biquads in Transposed Direct Form II. This form is more numerically robust than normal direct forms and is as easy and as efficient to implement. Though, a…
AQ - PR
- torvalds commented on issue #83 CommentPrefer SVF over DF1/DF2 biquads
Thanks for the pointer. I will check this out, because it's very much the kind of core low-level thing I'm trying to learn about. And I did do DF2 initially because I was lured in by the "canonical" …
TO - torvalds commented on issue #76 CommentUser experience in visualize.py
I suspect - but can't verify - that you are feeding it a 24-bit WAV file. This code is all extremely stupid, and the target is to (eventually) go back to a microcontroller hardware setup, so pretty m…
TO - torvalds commented on PR #65 CommentAdd simple TUI for effect and pot control
Would you mind looking at expanding this a bit for the new dynamic control functionality I added to the 'convert' binary? See commit ea71138 ("convert: add somewhat realtime control interface") which…
TO - torvalds commented on PR #52 CommentOptimize min/max calculation and memory allocation in visualize.py
I think this was made obsolete by commit 745e79b ("Update visualize.py: use raw int32 data, just scale the Y axis") which stopped normalizing the input entirely. But I don't know the internals of mat…
TO - torvalds commented on PR #58 CommentSimplify ffplay input handling in Makefile
This breaks my "SeymourDuncan" test case, which is just "repeat over some random mp3 samples of guitar pickups by Seymour Duncan". That's not a great test-case, but I don't have any actual reasonable…
TO - torvalds commented on issue #59 CommentPhaser filter instability when pot3 > 0.5
You are of course correct. A lot of the pots are very random ranges, but this one in particular more random than some. I think I was messing with it in order to get a much clearer response with the t…
TO - torvalds commented on issue #43 CommentQuestion about 52kHz sample rate vs standard 48kHz efficiency
The guitar pedal hardware does that 52k sample rate simply because that way it has a integer multiplier from the system clock (150MHz) to the i2s PIO engine that runs at twice the i2s BCLK. (In fact,…
TO - torvalds commented on PR #47 CommentAdd distortion effect with soft/hard/asymmetric clipping modes
Cherry-picked as commit cc47b99 ("Add a distortion/overdrive effect with clipping modes and tone control")
TO - torvalds commented on PR #54 CommentFix potential out-of-bounds access in fastsincos()
This is wrong. The quarter_sin[] array explicitly has an extra +1.0 entry at the end, and we do not want to wrap around (and get a zero instead). See 'gensin.c', and that last printf() outside the lo…
TO - torvalds commented on PR #49 CommentAdd basspurr effect for bass guitar even harmonics (fixes #18)
This is odd and doesn't even build. There is no "biquad_init_lfp()". Yes, I can see what is intended, but still.. Smells of AI hallucination.
TO - torvalds commented on issue #36 CommentVisualization tool fails on >10MB sample files — optimize plotting or chunk loading.
I'm sure you're right, but at the same time I want to make it very clear that the visualization tool is very secondary. IOW, it's a "Don't Do That Then" kind of situation. That visualizer is meant fo…
TO - torvalds commented on PR #39 Commentfix typo "pots" into "ports"
No, it's 'pots' - pot being short for 'potentiometer' (nobody has the energy to write that word out, so it's pretty universally shortened to pot).
TO - royna2544 approved PR #2 ReviewAdd requirements.txt for Python dependenciesRO
- torvalds commented on issue #32 Commentmake phaser: undefined reference to `sin'
Hopefully all fixed in current -git
TO - torvalds commented on PR #1 CommentMakefile: Allow overriding PLAY and PYTHON variables
As per some of the other pull requests, I can't merge things without DCO sign-off. That said, the only reason I used aplay is that it's simple on linux. But since the project uses ffmpeg anyway, I mi…
TO - torvalds commented on PR #13 CommentLDLIBS should be how you pass libraries
This was the right fix (eventually...) but I can only pull requests that have propelr DCO sign-off. I have credited you with a reported-by in the fix commit.
TO